Skip to content

Conversation

@mini-1235
Copy link
Contributor

@mini-1235 mini-1235 commented Jul 23, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on Ubuntu
Robotic platform tested on
Does this PR contain AI generated software? No
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

In yesterday PR, I noticed that some messages are included as .h some are .hpp, for example, there are some files that use

#include "nav_msgs/msg/path.hpp"

some

#include "nav_msgs/msg/path.h"

across the codebase, this PR update all message includes from .h to .hpp

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...ugins/action/compute_path_through_poses_action.hpp 100.00% <ø> (ø)
...ree/plugins/action/compute_path_to_pose_action.hpp 100.00% <ø> (ø)
...avior_tree/plugins/action/compute_route_action.hpp 100.00% <ø> (ø)
..._tree/plugins/action/get_pose_from_path_action.hpp 100.00% <ø> (ø)
...ehavior_tree/plugins/action/smooth_path_action.hpp 100.00% <ø> (ø)
...ee/include/nav2_behavior_tree/ros_topic_logger.hpp 100.00% <ø> (ø)
...tmap_2d/include/nav2_costmap_2d/costmap_2d_ros.hpp 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit 1dc2b58 into ros-navigation:main Jul 23, 2025
15 checks passed
@mini-1235 mini-1235 deleted the fix/c-headers branch July 23, 2025 16:51
SakshayMahna pushed a commit to SakshayMahna/navigation2 that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants