Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jul 10, 2025

This PR fixes a bad_weak_ptr error caused by passing a std::unique_ptr to (main)nav2_ros_common::createBond()( and nav2_util::createBond() in humble), which expects a std::shared_ptr. The incorrect ownership type led to invalid weak pointer dereferencing. This change ensures correct usage of shared_ptr to avoid runtime errors during bond creation.

* Update lifecycle_node.hpp :: createBond() -> bond_ type fix

Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>

* Update lifecycle_node.hpp

Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>

* Update lifecycle_node.hpp: removing extra spaces

Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>

---------

Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
(cherry picked from commit f10aa77)

# Conflicts:
#	nav2_ros_common/include/nav2_ros_common/lifecycle_node.hpp
@mergify mergify bot added the conflicts label Jul 10, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Jul 10, 2025

Cherry-pick of f10aa77 has failed:

On branch mergify/bp/humble/pr-5341
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit f10aa770.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   nav2_ros_common/include/nav2_ros_common/lifecycle_node.hpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify
Copy link
Contributor Author

mergify bot commented Jul 10, 2025

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @humble, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski deleted the mergify/bp/humble/pr-5341 branch July 10, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants