Skip to content

Conversation

@redvinaa
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #4809 )
Primary OS tested on Ubuntu
Robotic platform tested on custom gazebo simulation, custom hardware
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Added goal pose to MPPI CriticData
  • Now all critics can activate based on distance from global goal pose instead of pruned

Description of documentation updates required from your changes

  • Bugfix, usage doesn't change

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@redvinaa, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @humble, but it must be in main
to have these changes reflected into new distributions.

@redvinaa redvinaa force-pushed the mppi-goal-to-critic-humble branch from 4465836 to 2d61b3f Compare December 20, 2024 14:40
@redvinaa
Copy link
Contributor Author

Please check implementation and when everything is correct, I'll port to rolling

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

@redvinaa
Copy link
Contributor Author

redvinaa commented Jan 2, 2025

Can I have some help with the CI errors? I'm not sure it's because of my changes

@SteveMacenski
Copy link
Member

SteveMacenski commented Jan 3, 2025

@redvinaa the CI errors are because we don't expect PRs directly to existing distributions so its not setup correctly with the caching. You could have build / test issues, but we'd need to to have this opened against main to check for them. This PR is opened in the opposite direction we ususally do (main branch -> then backport to humble, if possible).

I'll review as-if build/tests are passing, but I won't merge into Humble until the same code on main is passing as a proxy

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Signed-off-by: redvinaa <[email protected]>
@redvinaa redvinaa mentioned this pull request Jan 3, 2025
@SteveMacenski SteveMacenski merged commit ad2f960 into ros-navigation:humble Jan 14, 2025
2 of 3 checks passed
SteveMacenski added a commit that referenced this pull request Sep 16, 2025
SteveMacenski added a commit that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants