-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add goal pose to CriticData #4812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add goal pose to CriticData #4812
Conversation
Signed-off-by: redvinaa <[email protected]>
4465836 to
2d61b3f
Compare
|
Please check implementation and when everything is correct, I'll port to rolling |
SteveMacenski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me
Signed-off-by: redvinaa <[email protected]>
Signed-off-by: redvinaa <[email protected]>
Signed-off-by: redvinaa <[email protected]>
|
Can I have some help with the CI errors? I'm not sure it's because of my changes |
|
@redvinaa the CI errors are because we don't expect PRs directly to existing distributions so its not setup correctly with the caching. You could have build / test issues, but we'd need to to have this opened against I'll review as-if build/tests are passing, but I won't merge into Humble until the same code on |
SteveMacenski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Signed-off-by: redvinaa <[email protected]>
Signed-off-by: redvinaa <[email protected]>
Signed-off-by: redvinaa <[email protected]>
Signed-off-by: redvinaa <[email protected]>
This reverts commit ad2f960.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: