Skip to content

replace throw-error with error-log to avoid UAF mentioned in #4175 #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2024
Merged

replace throw-error with error-log to avoid UAF mentioned in #4175 #4180

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ad0f39
replace throw-error with error-log to avoid UAF
Mar 14, 2024
6a41d35
fix typo
Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nav2_util/include/nav2_util/simple_action_server.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ class SimpleActionServer
if (steady_clock::now() - start_time >= server_timeout_) {
terminate_all();
if (completion_callback_) {completion_callback_();}
throw std::runtime_error("Action callback is still running and missed deadline to stop");
error_msg("Action callback is still running and missed deadline to stop")
}
}

Expand Down