Skip to content

Container retention via version tagging #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Container retention via version tagging #3491

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43f341f
Use github action expression syntax
ruffsl Mar 13, 2023
efdba15
Tag by version instead of by timestamp
ruffsl Mar 20, 2023
80750df
Avoid pushing untagged image to GHCR
ruffsl Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/update_ci_image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
trigger: ${{ steps.check.outputs.trigger }}
no_cache: ${{ steps.check.outputs.no_cache }}
container:
image: ghcr.io/ros-planning/navigation2:${{ github.ref_name }}
image: ghcr.io/${{ github.repository }}:${{ github.ref_name }}
steps:
- name: "Check apt updates"
id: check
Expand Down Expand Up @@ -74,8 +74,8 @@ jobs:
- name: Set build config
id: config
run: |
timestamp=$(date --utc +%Y%m%d%H%M%S)
echo "timestamp=${timestamp}" >> $GITHUB_OUTPUT
version=$(grep -oP '(?<=<version>).*?(?=</version>)' navigation2/package.xml)
echo "version=${version}" >> $GITHUB_OUTPUT

no_cache=false
if [ "${{needs.check_ci_files.outputs.no_cache}}" == 'true' ] || \
Expand All @@ -97,15 +97,16 @@ jobs:
id: docker_build
uses: docker/build-push-action@v4
with:
provenance: false
pull: true
push: true
no-cache: ${{ steps.config.outputs.no_cache }}
cache-from: type=registry,ref=ghcr.io/ros-planning/navigation2:${{ github.ref_name }}
cache-from: type=registry,ref=ghcr.io/${{ github.repository }}:${{ github.ref_name }}
cache-to: type=inline
target: builder
tags: |
ghcr.io/ros-planning/navigation2:${{ github.ref_name }}
ghcr.io/ros-planning/navigation2:${{ github.ref_name }}-${{ steps.config.outputs.timestamp }}
ghcr.io/${{ github.repository }}:${{ github.ref_name }}
ghcr.io/${{ github.repository }}:${{ github.ref_name }}-${{ steps.config.outputs.version }}
- name: Image digest
if: steps.config.outputs.trigger == 'true'
run: echo ${{ steps.docker_build.outputs.digest }}