revisit nav2_behavior_tree workarounds

[tonynajjar]

@SteveMacenski in #4298 you introduced some workarounds to account for issues in BT.CPP. This ticket is a reminder to address them once the fixes are done on BT.CPP's side

[SteveMacenski]

Are you referring to

add_compile_options(-Wno-shadow) # Delete after https://github.com/BehaviorTree/BehaviorTree.CPP/issues/811 is released

Or anything else?

[tonynajjar]

You added some more things in nav2_behavior_tree, not sure if these are workarounds or here to stay. From my stuff yes just this

[SteveMacenski]

Those are to stay, that's a feature of the new BT.CPP versions. Possibly a regression, but also doesn't really matter since its something that only comes up in the isolated testing environment. I could type it all out, but suffice it to say its not worth concern.

[SteveMacenski]

#4500 Addresses