Skip to content

RELEASE REPO BASE env var #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2018
Merged

RELEASE REPO BASE env var #460

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ac4059
RELEASE REPO BASE env var
DLu Feb 5, 2018
9ff4361
Add docstring
DLu Feb 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions bloom/commands/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import os
import pkg_resources
import platform
import requests
import shutil
import subprocess
import sys
Expand Down Expand Up @@ -296,6 +297,16 @@ def validate_github_url(url, url_type):
return True


def infer_release_repo_from_env(repository):
Copy link
Contributor

@nuclearsandwich nuclearsandwich Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a docstring to this function describing the environment variable's behavior.

base = os.environ.get('BLOOM_RELEASE_REPO_BASE', None)
if base is None:
return None
url = base + repository + '-release.git'
r = requests.get(url)
if r.status_code == requests.codes.ok:
return url


def get_repo_uri(repository, distro):
url = None
# Fetch the distro file
Expand All @@ -309,6 +320,8 @@ def get_repo_uri(repository, distro):
matches = difflib.get_close_matches(repository, distribution_file.repositories)
if matches:
info(fmt("@{yf}Did you mean one of these: '" + "', '".join([m for m in matches]) + "'?"))
if url is None:
url = infer_release_repo_from_env(repository)
if url is None:
info("Could not determine release repository url for repository '{0}' of distro '{1}'"
.format(repository, distro))
Expand Down