-
Notifications
You must be signed in to change notification settings - Fork 99
RELEASE REPO BASE env var #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RELEASE REPO BASE env var #460
Conversation
wjwwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is fine, but honestly I don't think it should be needed most of the time. If the package has ever been released on a previous ROS distribution, then it will guess it from the previous one. If it's already been released into the current ROS distro, then it doesn't need the url (it will use the one from the previous release).
So this only applies on the first release of a package ever in any ros distribution. But if you find it useful, then that's fine I guess.
|
I know bloom's documentation isn't in the best of shape, but I would love to see this new feature documented somewhere so I can add documentation for more of the environment variables used by Bloom. |
nuclearsandwich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see at least a docstring on the added function. If you're really feeling your oats and want to add a unit test or a section in the docs I would be very grateful. But I don't think either would necessarily block the PR.
bloom/commands/release.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a docstring to this function describing the environment variable's behavior.
|
I would be willing to add a test or some documentation, but I'm unclear where it would go best. I'm not familiar with the test structures in this package, and it seems like the documentation should just go on the wiki. |
|
Thanks for the docstring DLu. I'll admit that I'm also getting familiar with the test structures so I don't have much concrete advice for you on that front. I'm going to merge this so we can add support in the next release. |
BLOOM_RELEASE_REPO_BASE.BLOOM_RELEASE_REPO_BASE+ repository + '-release.git' exists as a repository, then it will use that as the release repo.https://github.com/wu-robotics/so if I set that as my environment variable, I can create abloom-example-releaserepo there, and then if I try tobloom-releasea package calledbloom-example, it will automagically use that as my release repo.