Add parsing robot_description via xacro. #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Did it work for you? Can you reformat code according to pep8 (line lengths) - mostly how it was? And can you check it with ament_* tools. I will merge this without passing CI. Thanks! |
Contributor
Author
It worked for me like a charm. It is also possible to use |
Member
|
Thanks! I just adjusted a bit more. There was an old issue from my side with |
bmagyar
added a commit
that referenced
this pull request
Dec 5, 2020
* Implementation of RRBot System Headless Hardware with only position joints. * rrbot system position only after first testing. * Added description of rrbot and example ros2_control_manager. * ROS2 Managers are moved to controller_interface package * Update README.md * Change package names to represent the actual state. * Describe connection to the example URDFs * Add controlle to example 1 and adapt the hardware to provide more sensible example. * Added controller to install path * Change parameter names because deprecated * Reorganize controller's yaml to have correct parameters' namespace. Comment out the name of the node from the roslaunch file to avoid issue with LifecycleNode-Names. Add better robot's movement simulation. * Corrected licence header and add explicit type instead of auto * Update README.md * Update parameter and launch * Update README.md * Reorganize to new RM structure * Update README.md * Updated to new status * Adapt brances and additional output * Add parsing robot_description via xacro. (#45) * Add parsing robot_description via xacro. Co-authored-by: Denis Štogl <[email protected]> * Remove URDF file * Update description * Update linters.yaml * Update ci.yml * Add dependencies * Update ci.yml * Update CMakeLists.txt * Update package.xml * Delete code_coverage.yml * Update ci.yml * Update ci.yml * Update linters.yaml * Update linters.yaml * Update ros2_control_demo_hardware/include/ros2_control_demo_hardware/rrbot_system_position_only.hpp Co-authored-by: Bence Magyar <[email protected]> * Update ros2_control_demo_hardware/src/rrbot_system_position_only.cpp Co-authored-by: Bence Magyar <[email protected]> * Address review comments. Co-authored-by: livanov93 <[email protected]> Co-authored-by: Bence Magyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.