Skip to content

Add first example robot (rrbot as system) #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Dec 5, 2020
Merged

Add first example robot (rrbot as system) #37

merged 40 commits into from
Dec 5, 2020

Conversation

@destogl
Copy link
Member

@destogl destogl commented Sep 11, 2020 •
edited
Loading

Some TODOs:

  • add xacro dependecy
  • parse robot's description from the xacro file
  • remove urdf file

This was referenced Sep 11, 2020
Closed
Open
destogl
destogl commented Sep 12, 2020
View reviewed changes
destogl
destogl commented Sep 12, 2020
View reviewed changes
This was referenced Sep 12, 2020
Merged
Closed
@destogl destogl mentioned this pull request Sep 15, 2020
Closed
AndyZe
AndyZe reviewed Sep 21, 2020
View reviewed changes
@destogl
Update README.md
c0e60ab 
* Change package names to represent the actual state.
* Describe connection to the example URDFs
@destogl destogl mentioned this pull request Sep 23, 2020
Open
destogl and others added 10 commits October 1, 2020 11:13
@destogl
Add controlle to example 1 and adapt the hardware to provide more sen…
f6fddee 
…sible example.
@destogl
Merge branch 'add_rrbot_system_position_joints' of https://github.com…
8336c52 
…/ros-controls/ros2_control_demos into add_rrbot_system_position_joints
@destogl
Added controller to install path
bb0d4c3
@destogl
Change parameter names because deprecated
4edaf31
@destogl
Reorganize controller's yaml to have correct parameters' namespace. C…
87bf1fe 
…omment out the name of the node from the roslaunch file to avoid issue with LifecycleNode-Names.

Add better robot's movement simulation.
@destogl
Corrected licence header and add explicit type instead of auto
8eec4e0
@destogl
Update README.md
81f6551
@destogl
Update parameter and launch
ccfb6e5
@destogl
Merge branch 'add_rrbot_system_position_joints' of https://github.com…
ec0f715 
…/ros-controls/ros2_control_demos into add_rrbot_system_position_joints
@destogl
Update README.md
de05e13
@destogl destogl mentioned this pull request Nov 13, 2020
Merged
@codecov-io
Copy link

codecov-io commented Dec 3, 2020 •
edited
Loading

Codecov Report

Merging #37 (732a3bc) into master (85450cc) will decrease coverage by 100.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##            master     #37        +/-   ##
============================================
- Coverage   100.00%   0.00%   -100.00%     
============================================
  Files            4       1         -3     
  Lines            4      71        +67     
============================================
- Hits             4       0         -4     
- Misses           0      71        +71
Flag Coverage Δ
unittests 0.00% <ø> (-100.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l_demo_hardware/src/rrbot_system_position_only.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4968d...732a3bc. Read the comment docs.

@destogl destogl mentioned this pull request Dec 3, 2020
Merged
bmagyar
bmagyar requested changes Dec 4, 2020
View reviewed changes
jordan-palacios
jordan-palacios approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@jordan-palacios jordan-palacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring @bmagyar comments, LGTM.

@bmagyar
Copy link
Member

bmagyar commented Dec 5, 2020 •
edited
Loading

@destogl I'm happy to update these components (let's merge soon) once ros-controls/ros2_control#258 is merged. I'm happy to merge this now

This was referenced Dec 5, 2020
Closed
Open
bmagyar
bmagyar approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with latest master of framework and controllers, nice work!
Also tested all commands in the readme

@bmagyar bmagyar merged commit 3dfe077 into master Dec 5, 2020
@bmagyar bmagyar mentioned this pull request Dec 5, 2020
Closed
@destogl destogl deleted the add_rrbot_system_position_joints branch December 5, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmagyar bmagyar bmagyar approved these changes

@v-lopez v-lopez Awaiting requested review from v-lopez

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

+2 more reviewers

@AndyZe AndyZe AndyZe left review comments

@jordan-palacios jordan-palacios jordan-palacios approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@destogl @codecov-io @bmagyar @AndyZe @jordan-palacios @livanov93