Skip to content

Standardize custom events, add is* helpers#103

Merged
TwitchBronBron merged 3 commits intomasterfrom
refactor-custom-events
Aug 30, 2022
Merged

Standardize custom events, add is* helpers#103
TwitchBronBron merged 3 commits intomasterfrom
refactor-custom-events

Conversation

@TwitchBronBron
Copy link
Member

@TwitchBronBron TwitchBronBron commented Aug 30, 2022

  • Standardize the custom events sent from the debug adapter to the client.
  • add is* helper functions for each event that abstracts the need to hardcode magic strings in the client.
  • restructure the LogOutputEvent and DebugServerLogOutputEvent bodies to be an object so we can more easily expand upon them in the future without breaking backwards compatibility.

NOTE: this is technically a breaking change since the event names and some structures have changed, so the vscode extension will need to be updated at the same to support these changes.

Depends on:

@TwitchBronBron TwitchBronBron merged commit 10b3fcf into master Aug 30, 2022
@TwitchBronBron TwitchBronBron deleted the refactor-custom-events branch August 30, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants