Fix for adding files on beforeProgramValidate

src/Program.spec.ts

@@ -669,6 +669,27 @@ describe('Program', () => {
             }
             expect(error?.message).to.eql('Crash for test');
         });
+
+        it('includes files added during beforeProgramValidate in validation', () => {
+            program.setFile('source/a.brs', `
+                sub a()
+                    b()
+                end sub
+            `);
+
+            program.plugins.add({
+                name: 'add file in beforeProgramValidate',
+                beforeProgramValidate: () => {
+                    program.setFile('source/b.brs', `
+                        sub b()
+                        end sub
+                    `);
+                }
+            });
+
+            program.validate();
+            expectZeroDiagnostics(program);
+        });
     });
 
     describe('hasFile', () => {

src/Program.ts

@@ -727,7 +727,7 @@ export class Program {
                 this.plugins.emit('beforeProgramValidate', this);
                 beforeProgramValidateWasEmitted = true;
             })
-            .forEach(Object.values(this.files), (file) => {
+            .forEach(() => Object.values(this.files), (file) => {
                 if (!file.isValidated) {
                     this.plugins.emit('beforeFileValidate', {
                         program: this,

src/common/Sequencer.ts

@@ -26,13 +26,25 @@ export class Sequencer {
     // eslint-disable-next-line @typescript-eslint/ban-types
     private actions: Array<{ args: any[]; func: Function }> = [];
 
-    public forEach<T>(items: T[], func: (item: T) => any) {
-        for (const item of items) {
-            this.actions.push({
-                args: [item],
-                func: func
-            });
-        }
+    public forEach<T>(itemsOrFactory: Iterable<T> | (() => Iterable<T>), func: (item: T) => any) {
+        //register a single action for now, we will fetch the full list and register their actions later
+        const primaryAction = {
+            args: [],
+            func: (data) => {
+                const items = typeof itemsOrFactory === 'function' ? itemsOrFactory() : itemsOrFactory;
+                const actions: Sequencer['actions'] = [];
+                for (const item of items) {
+                    actions.push({
+                        args: [item],
+                        func: func
+                    });
+                }
+                let primaryActionIndex = this.actions.indexOf(primaryAction);
+                //insert all of these item actions immediately after this action
+                this.actions.splice(primaryActionIndex + 1, 0, ...actions);
+            }
+        };
+        this.actions.push(primaryAction);
         return this;
     }