Skip to content

Fix for adding files on beforeProgramValidate#1568

Merged
TwitchBronBron merged 2 commits intorokucommunity:masterfrom
iBicha:fix/add-files-before-program-validation
Sep 11, 2025
Merged

Fix for adding files on beforeProgramValidate#1568
TwitchBronBron merged 2 commits intorokucommunity:masterfrom
iBicha:fix/add-files-before-program-validation

Conversation

@iBicha
Copy link
Contributor

@iBicha iBicha commented Sep 9, 2025

Closes #1450
Based on suggestion iBicha#1 (comment)

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me. Could you possibly add a unit test or two that ensures the behavior you're fixing is fixed?

@iBicha
Copy link
Contributor Author

iBicha commented Sep 9, 2025

The logic looks good to me. Could you possibly add a unit test or two that ensures the behavior you're fixing is fixed?

Yeah I missed that, added

@iBicha
Copy link
Contributor Author

iBicha commented Sep 9, 2025

I don't know why CI is failing, it looks like it could be an unsuitability (I see it related to workers?)
It's passing on my mac

@iBicha
Copy link
Contributor Author

iBicha commented Sep 10, 2025

I cleared node_modules and redid

npm ci
npm run build
npm run test

Things passed
The only difference I could think of is node version - which is 16.20.2 that's pretty old, should it be at least at LTS version?

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think the unit tests were failing because github was just having a bad day. i reran them and it passed now. So we'll just hope it's fine moving forward, but definitely not something your code introduced.

@TwitchBronBron TwitchBronBron merged commit 453aa49 into rokucommunity:master Sep 11, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files set at beforeProgramValidate stage are no longer picked up during validation of other real .bs files

2 participants