Fix for adding files on beforeProgramValidate#1568
Fix for adding files on beforeProgramValidate#1568TwitchBronBron merged 2 commits intorokucommunity:masterfrom
Conversation
TwitchBronBron
left a comment
There was a problem hiding this comment.
The logic looks good to me. Could you possibly add a unit test or two that ensures the behavior you're fixing is fixed?
Yeah I missed that, added |
|
I don't know why CI is failing, it looks like it could be an unsuitability (I see it related to workers?) |
|
I cleared node_modules and redid Things passed |
TwitchBronBron
left a comment
There was a problem hiding this comment.
Looks good! I think the unit tests were failing because github was just having a bad day. i reran them and it passed now. So we'll just hope it's fine moving forward, but definitely not something your code introduced.
Closes #1450
Based on suggestion iBicha#1 (comment)