Congruence tactics now handle primitive ints / floats / strings #20810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no point in keeping it inside, even though we have two different notions of boolean equality, they are registered with different handlers.
ppedrot
added
kind: enhancement
coqbot-app
bot
removed
the
request: full CI
Contributor
|
🔴 CI failure at commit 8e43342 without any failure in the test-suite ✔️ Corresponding job for the base commit 0d5abae succeeded ❔ Ask me to try to extract a minimal test case that can be added to the test-suite 🏃
|
Janno
approved these changes
Jun 25, 2025
ppedrot
added a commit
to ppedrot/coq-elpi
that referenced
this pull request
Jun 26, 2025
gares
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Jun 26, 2025
SkySkimmer
approved these changes
Jun 26, 2025
SkySkimmer
added
the
needs: changelog entry
Contributor
|
changelog? |
coqbot-app
bot
added
the
needs: full CI
ppedrot
removed
needs: changelog entry
Member
Author
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
Contributor
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't implement congruence for arrays yet, this requires a little bit more work.
Fixes #20011.