Skip to content

Conversation

@ppedrot
Copy link
Collaborator

@ppedrot ppedrot commented Jun 26, 2025

This is backwards compatible.

@ppedrot ppedrot requested a review from Copilot June 26, 2025 07:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adapts the proof in PrimStringAxioms.v.in to reference the updated eqb from the PrimInt63 module, aligning with upstream changes in rocq-prover/rocq#20810 while preserving backwards compatibility.

  • Qualify eqb in the proof to avoid ambiguity after the upstream refactor.
Comments suppressed due to low confidence (1)

theories/core/PrimStringAxioms.v.in:21

  • [nitpick] Consider importing PrimInt63.eqb (e.g., Import PrimInt63.) or opening a local module at the top of the file to avoid fully qualifying eqb each time and improve readability.
#[skip="8.20"]   move: (eqb_correct x y); case: PrimInt63.eqb => [/(_ isT)->|_].

@gares
Copy link
Contributor

gares commented Jun 26, 2025

Thanks @copilot your wisdom has no match!

@gares gares merged commit 6ef0cca into LPCIC:master Jun 26, 2025
94 of 98 checks passed
@ppedrot ppedrot deleted the cctac-primitive-values branch June 26, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants