Skip to content

Proposed alternate API for bitwise operations on MutableBuffer #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: add-bitwise-ops-to-boolean-buffer-builder
Choose a base branch
from
Open

Proposed alternate API for bitwise operations on MutableBuffer #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2184c2a
remove MutableOpsBufferSupportedLhs and use unsafe mutable_buffer fun…
alamb Oct 24, 2025
5c67b8a
Remove BufferSupportedRhs in favor of `AsRef<[u8]>`
alamb Oct 24, 2025
30ea4df
Proposal: Move mutable_bitwise_bin_op_helper and .mutable_bitwise_un…
alamb Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions arrow-buffer/src/buffer/immutable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,12 @@ impl From<&[u8]> for Buffer {
}
}

impl AsRef<[u8]> for &Buffer {
fn as_ref(&self) -> &[u8] {
self.as_slice()
}
}

impl<const N: usize> From<[u8; N]> for Buffer {
fn from(p: [u8; N]) -> Self {
Self::from_slice_ref(p)
Expand Down
1 change: 0 additions & 1 deletion arrow-buffer/src/buffer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ pub use mutable::*;
mod ops;
pub use ops::*;
mod mutable_ops;
pub use mutable_ops::*;
mod scalar;
pub use scalar::*;
mod boolean;
Expand Down
6 changes: 6 additions & 0 deletions arrow-buffer/src/buffer/mutable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,12 @@ impl MutableBuffer {
}
}

impl AsRef<[u8]> for &MutableBuffer {
fn as_ref(&self) -> &[u8] {
self.as_slice()
}
}

impl Default for MutableBuffer {
fn default() -> Self {
Self::with_capacity(0)
Expand Down
Loading