Proposed alternate API for bitwise operations on MutableBuffer
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
changed the title
MutableBuffer
alamb
commented
Oct 24, 2025
| assert_eq!(self.len, rhs.len()); | ||
|
|
||
| mutable_buffer_bin_or(&mut self.buffer, 0, rhs.inner(), rhs.offset(), self.len); | ||
| self.buffer.mutable_bitwise_bin_op_helper( |
Author
There was a problem hiding this comment.
this illustrates the new API well -- it becomes a method on MutableBuffer itself and then these functions simply call into that method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sketch of an alternate API for
apply_unary_opandapply_binary_opbitwise operations apache/arrow-rs#8619Basically, instead of new free functions and traits, it adds two new methods to
MutableBufferthat apply the bitwise operations in an optimized fashionI have not yet ported the tests, but would do so if you like this
It includes the changes in these two PRs
AsRef<[u8]>#1MutableOpsBufferSupportedLhsand use unsafe mutable_buffer function #2