Skip to content

Comments

Fix crash/freeze when zooming out too far in a plot#5737

Merged
emilk merged 1 commit intomainfrom
emilk/fix-plot-crashes
Apr 2, 2024
Merged

Fix crash/freeze when zooming out too far in a plot#5737
emilk merged 1 commit intomainfrom
emilk/fix-plot-crashes

Conversation

@emilk
Copy link
Member

@emilk emilk commented Apr 2, 2024

What

We reach i64::MAX pretty quickly when zooming out on e.g. https://github.com/rerun-io/example-rs-github-stars.

In debug builds this overflow would lead to a crash. In release I think it results in a freeze.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 💣 crash crash, deadlock/freeze, do-no-start include in changelog 📺 re_viewer affects re_viewer itself labels Apr 2, 2024
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early signs of year 2038 :)

@emilk emilk merged commit d00aa27 into main Apr 2, 2024
@emilk emilk deleted the emilk/fix-plot-crashes branch April 2, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💣 crash crash, deadlock/freeze, do-no-start include in changelog 📺 re_viewer affects re_viewer itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants