URDF loader: use InstancePoses3D for geometry scale#12371
Merged
Conversation
oxkitsune
added
🪳 bug
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
MichaelGrupp
approved these changes
Jan 9, 2026
Member
|
oops... good catch! Thanks. |
ntjohnson1
pushed a commit
that referenced
this pull request
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In #12005 we started logging the origin transforms for geometry using
InstancePoses3D. However the mesh scale was still being logged using a normalTransform3D, this fixes that and now meshes with a scale attribute should be scaled correctly.Originally reported on our discord: https://discord.com/channels/1062300748202921994/1458859702359167106