Removes remnants of indicators from dataframe queries and viewer#10584
Merged
Removes remnants of indicators from dataframe queries and viewer#10584
Conversation
grtlr
added
📺 re_viewer
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
approved these changes
Jul 10, 2025
Member
abey79
left a comment
abey79
left a comment
There was a problem hiding this comment.
Had a cursory look, didn't see anything shocking. Thanks for pulling that off
Comment on lines
+613
to
+616
| pub fn header_cell_margin(&self, _table_style: TableStyle) -> Margin { | ||
| Margin::symmetric(8, 6) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Is this an easter egg to test the reviewer? :)
Member
Author
There was a problem hiding this comment.
Ahaha, nah just a bad rebase. The diff should be much nicer now that #10581 is merged.
grtlr
force-pushed
the
grtlr/remove-is-indicator-from-dataframe
branch
from
06bfb82 to
346f250
Compare
grtlr
changed the title
grtlr
force-pushed
the
grtlr/remove-is-indicator-from-dataframe
branch
from
346f250 to
923696f
Compare
Member
Author
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/16205572522 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
split_indicatorsfromChunkBatcher#10583rerun_py, andrerun_cpp#10581What
This removes the remaining reference to indicators from our codebase. Most notably this removes indicators from the dataframe queries and the UI.
This should be fine because:
Important
There is some risk that this PR will make indicators appear again, so we should choose a good time to merge this PR. If they show up again then let's fix the root cause (i.e. migration logic).
TODO