Address remaining TODO(#8129)s

Author: grtlr

crates/store/re_sorbet/src/migrations/v0_0_2__to__v0_1_0.rs

@@ -72,7 +72,6 @@ fn rewire_tagged_components(batch: &RecordBatch) -> RecordBatch {
 
             if field.name().ends_with("Indicator") {
                 let field_name = field.name();
-                // TODO(#8129): Remove indicator components
                 re_log::debug_once!(
                     "Moving indicator from field to component metadata field: {field_name}"
                 );
@@ -112,7 +111,6 @@ fn rewire_tagged_components(batch: &RecordBatch) -> RecordBatch {
                     }
                     (None, Some(archetype_field)) => (None, archetype_field, Some(component)),
                     (maybe_archetype, None) if component.ends_with("Indicator") => {
-                        // TODO(#8129): For now, this renames the indicator column metadata. Eventually, we want to remove the column altogether.
                         re_log::debug_once!(
                             "Moving indicator to component field: {component}"
                         );

crates/viewer/re_redap_browser/src/servers.rs

@@ -222,10 +222,18 @@ impl Server {
                 entity_path.starts_with(&std::iter::once(EntityPathPart::properties()).collect())
             }) {
                 // Property column, just hide indicator components
-                //TODO(#8129): remove this when we no longer have indicator components
-                !desc
+                // TODO(grtlr): Indicators are gone, but since servers might still
+                // have this column we keep this check for now.
+                let is_indicator = desc
                     .column_name(BatchType::Dataframe)
-                    .ends_with("Indicator")
+                    .ends_with("Indicator");
+                if is_indicator {
+                    re_log::warn_once!(
+                        "Encountered unexpected indicator column name: {}",
+                        desc.column_name(BatchType::Dataframe)
+                    )
+                }
+                !is_indicator
             } else {
                 matches!(
                     desc.display_name().as_str(),

crates/viewer/re_viewer_context/src/view/visualizer_system.rs

@@ -14,6 +14,8 @@ use crate::{
 #[derive(Debug, Clone, Default)]
 pub struct SortedComponentDescriptorSet(linked_hash_map::LinkedHashMap<ComponentDescriptor, ()>);
 
+pub type UnorderedArchetypeSet = IntSet<ArchetypeName>;
+
 impl SortedComponentDescriptorSet {
     pub fn insert(&mut self, k: ComponentDescriptor) -> Option<()> {
         self.0.insert(k, ())
@@ -41,8 +43,7 @@ impl FromIterator<ComponentDescriptor> for SortedComponentDescriptorSet {
 pub struct VisualizerQueryInfo {
     /// These are not required, but if _any_ of these are found, it is a strong indication that this
     /// system should be active (if also the `required_components` are found).
-    // TODO(#8129): Consider making this a proper struct to make the semantics of `Default::default()` clearer.
-    pub relevant_archetypes: IntSet<ArchetypeName>,
+    pub relevant_archetypes: UnorderedArchetypeSet,
 
     /// Returns the minimal set of components that the system _requires_ in order to be instantiated.
     ///