Skip to content

Add CLI for show events-counters #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbud-msft merged 10 commits into from
Oct 20, 2022
Merged

Add CLI for show events-counters #1

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4cf344a
Added event
renukamanavalan Aug 18, 2022
5422632
remove unused import
renukamanavalan Aug 18, 2022
687fe7b
remove unused import
renukamanavalan Aug 18, 2022
e8edb2e
LGTM warning fixed
renukamanavalan Aug 18, 2022
3f9ee1c
Merge remote-tracking branch 'upstream/master' into statistics
renukamanavalan Sep 8, 2022
d7176a0
drop settig explicit log level
renukamanavalan Sep 8, 2022
03f7db4
Merge remote-tracking branch 'upstream/master' into statistics
renukamanavalan Sep 16, 2022
d78c65f
Add CLI command to show stats
renukamanavalan Sep 16, 2022
1a09f49
name update
renukamanavalan Sep 16, 2022
1ab8284
Merge remote-tracking branch 'origin/events_shared' into statistics
renukamanavalan Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions show/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,32 @@ def vrf(vrf_name):
body.append(["", intf])
click.echo(tabulate(body, header))

#
# 'events' command ("show event-counters")
#

@cli.command()
def event_counters():
"""Show events counter"""
# dump keys as formatted
counters_db = SonicV2Connector(host='127.0.0.1')
counters_db.connect(counters_db.COUNTERS_DB, retry_on=False)

header = ['name', 'count']
keys = counters_db.keys(counters_db.COUNTERS_DB, 'COUNTERS_EVENTS*')
table = []

for key in natsorted(keys):
key_list = key.split(':')
data_dict = counters_db.get_all(counters_db.COUNTERS_DB, key)
table.append((key_list[1], data_dict["value"]))
Copy link
Copy Markdown
Collaborator

@zbud-msft zbud-msft Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if key_list will ever be empty but maybe add sanity check that we are not accessing empty array

Copy link
Copy Markdown
Owner Author

@renukamanavalan renukamanavalan Oct 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never.
< table name >:< keyname >

True for every redis entry


if table:
click.echo(tabulate(table, header, tablefmt='simple', stralign='right'))
else:
click.echo('No data available in COUNTERS_EVENTS\n')


#
# 'arp' command ("show arp")
#
Expand Down