Add CLI for show events-counters#1
Merged
zbud-msft merged 10 commits intoevents_sharedfrom Oct 20, 2022
Merged
Conversation
zbud-msft
reviewed
Oct 18, 2022
| for key in natsorted(keys): | ||
| key_list = key.split(':') | ||
| data_dict = counters_db.get_all(counters_db.COUNTERS_DB, key) | ||
| table.append((key_list[1], data_dict["value"])) |
Collaborator
There was a problem hiding this comment.
Not sure if key_list will ever be empty but maybe add sanity check that we are not accessing empty array
Owner
Author
There was a problem hiding this comment.
Never.
< table name >:< keyname >
True for every redis entry
zbud-msft
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->