Skip to content

Support HMR/HDR for Client Data #8189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 4, 2023
Merged

Support HMR/HDR for Client Data #8189

merged 10 commits into from
Dec 4, 2023

Conversation

@brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Nov 30, 2023 •
edited
Loading

Quick stab at duplicating the current loader HDR logic to apply to clientLoader

No need to duplicate - can just check the exports slightly differently in the current plugin.

Vite HDR is working. HMR of HydrateFallback is not working currently - see TODO comment in the code

@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4525fd0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 added package:dev feat:dx Issues related to the developer experience labels Dec 1, 2023
@brophdawg11 brophdawg11 mentioned this pull request Dec 1, 2023
Merged
4 tasks
@brophdawg11 brophdawg11 changed the title First pass at HDR for clientLoader Support HMR/HDR for Client Data Dec 1, 2023
@brophdawg11 brophdawg11 force-pushed the brophdawg11/client-data-hdr branch from f4bb9f3 to c6e9e1e Compare December 1, 2023 21:55
brophdawg11
brophdawg11 commented Dec 4, 2023
View reviewed changes
packages/remix-dev/devServer_unstable/hdr.ts
} else if (theExports.includes("clientLoader")) {
contents = `export { clientLoader } from ${JSON.stringify(
`./${file}`
)};`;
Copy link
Contributor Author

@brophdawg11 brophdawg11 Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable HDR for clientLoader by adapting the current tree shaking approach for fine-grained loader-change detection to also support clientLoader. Need these branches since esbuild will complain if we try to import a non-existent named export

brophdawg11
brophdawg11 commented Dec 4, 2023
View reviewed changes
packages/remix-dev/vite/plugin.ts
"HydrateFallback",
"action",
"clientAction",
"clientLoader",
Copy link
Contributor Author

@brophdawg11 brophdawg11 Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow these to be exported from a route module

brophdawg11
brophdawg11 commented Dec 4, 2023
View reviewed changes
packages/remix-dev/vite/plugin.ts
"handle",
"meta",
"links",
"shouldRevalidate",
Copy link
Contributor Author

@brophdawg11 brophdawg11 Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add non-component exports to accept for hot updates

@brophdawg11 brophdawg11 merged commit a2b26d3 into feature/client-data Dec 4, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/client-data-hdr branch December 4, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed feat:dx Issues related to the developer experience package:dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brophdawg11