Skip to content

Add isClosedConversation #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Add isClosedConversation #120

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
802f8e5
Add "Status: Closed as not planned" to `isClosedPR`
yakov116 Jul 7, 2022
1652853
deprecate `isClosedPR`
yakov116 Jul 7, 2022
da62012
One line
yakov116 Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,11 @@ collect.set('isQuickPR', [
export const isDraftPR = (): boolean => exists('#partial-discussion-header [title="Status: Draft"]');
export const isOpenPR = (): boolean => exists('#partial-discussion-header [title="Status: Open"], #partial-discussion-header [title="Status: Draft"]');
export const isMergedPR = (): boolean => exists('#partial-discussion-header [title="Status: Merged"]');
export const isClosedPR = (): boolean => exists('#partial-discussion-header [title="Status: Closed"], #partial-discussion-header [title="Status: Merged"]');
export const isClosedConversation = (): boolean => exists('#partial-discussion-header :is([title="Status: Closed"], [title="Status: Merged"], [title="Status: Closed as not planned]")');
Copy link
Member

@fregante fregante Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

/**
@deprecated Use isClosedConversation
*/
Copy link
Member

@fregante fregante Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/** */ also works on one line

export const isClosedPR = isClosedConversation;

export const isReleases = (url: URL | HTMLAnchorElement | Location = location): boolean => getRepo(url)?.path === 'releases';
collect.set('isReleases', [
Expand Down