Add isClosedConversation
#120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
You're right, we're always using it as an exclusion on PRs that already have PR-only include anyway. Can you deprecate We can drop |
Member
Author
|
Random.... Online editor is Awesome!! Love the |
Member
Author
|
🚀 ? |
yakov116
changed the title
isClosedPRisClosedConversation
fregante
approved these changes
Jul 7, 2022
index.ts
Outdated
| export const isClosedConversation = (): boolean => exists('#partial-discussion-header :is([title="Status: Closed"], [title="Status: Merged"], [title="Status: Closed as not planned]")'); | ||
| /** | ||
| @deprecated Use isClosedConversation | ||
| */ |
fregante
changed the title
isClosedConversationisClosedConversation
Member
Author
|
Um this PR makes GitHub crash 🎉. Maybe the |
Member
Author
Yup |
Member
Author
|
Ouch I see why... |
fregante
reviewed
Jul 7, 2022
| export const isOpenPR = (): boolean => exists('#partial-discussion-header [title="Status: Open"], #partial-discussion-header [title="Status: Draft"]'); | ||
| export const isMergedPR = (): boolean => exists('#partial-discussion-header [title="Status: Merged"]'); | ||
| export const isClosedPR = (): boolean => exists('#partial-discussion-header [title="Status: Closed"], #partial-discussion-header [title="Status: Merged"]'); | ||
| export const isClosedConversation = (): boolean => exists('#partial-discussion-header :is([title="Status: Closed"], [title="Status: Merged"], [title="Status: Closed as not planned]")'); |
This was referenced Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really this should be renamed to
isClosedConversationbut...