feat(vectorset): add VISMEMBER & WITHATTRIBS#3753
Merged
ndyakov merged 16 commits intoredis:masterfrom Apr 9, 2026
Merged
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ndyakov
previously approved these changes
Apr 7, 2026
Member
ndyakov
left a comment
ndyakov
left a comment
There was a problem hiding this comment.
Overall looks good, nothing blocking, but would like to see the comments resolved before merging. Thank you @romanpovol!
Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
…instead of custom functions (redis#3758) * Optimize: Use modern Go standard library (maps.Keys, slices.Collect, slices.Contains) instead of custom functions * format
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5 to 6. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5...v6) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…redis#3762) * ring: remove external rendezvous dependency by inlining implementation Replace usage of github.com/dgryski/go-rendezvous with an internal implementation to eliminate the external dependency and avoid licence propagation concerns. The implementation preserves the exact hashing algorithm and behaviour: - same hash combination: khash ^ nhash - same mixing function (xorshift* variant) - same node ordering semantics No functional changes intended. * Refactor TestRendezvous to remove randomString function Replaced function with inline string generation for test cases. * test: refactor RendezvousHash tests to use Ginkgo and Gomega * test: improve RendezvousHash test for per-instance determinism and distribution balance * test: enhance distribution verification in RendezvousHash tests
ndyakov
previously approved these changes
Apr 9, 2026
Member
ndyakov
left a comment
ndyakov
left a comment
There was a problem hiding this comment.
Looks good, thank you @romanpovol
ndyakov
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds new vectorset commands and new reply-parsing paths (RESP2/RESP3, nullable attribute strings), which could cause mis-parsing or backward-compat issues if Redis returns unexpected shapes; changes are otherwise localized to vectorset APIs and tests.
Overview
Extends vectorset API surface by adding
VISMEMBERplus newVSIMvariants that request element attributes viaWITHATTRIBS(optionally combined withWITHSCORES).Introduces new command result types/parsers (
VectorAttribSliceCmd,VectorScoreAttribSliceCmdandVectorAttrib/VectorScoreAttrib) that handle both RESP2 flat arrays and RESP3 maps, includingnilattribute payloads.Also fixes the
VSIMargument key forEpsilonto emit lowercaseepsilon, and updates unit/integration tests and doctest examples to cover the new commands and reply formats.Reviewed by Cursor Bugbot for commit 1cb643a. Bugbot is set up for automated code reviews on this repo. Configure here.