Fix VectorScoreSliceCmd to handle RESP2 flat array responses#3767
Merged
Fix VectorScoreSliceCmd to handle RESP2 flat array responses#3767
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
Agent-Logs-Url: https://github.com/redis/go-redis/sessions/98c71a51-26cc-46ab-b9a0-25bd9c1f3295 Co-authored-by: ndyakov <[email protected]>
…uctor Agent-Logs-Url: https://github.com/redis/go-redis/sessions/98c71a51-26cc-46ab-b9a0-25bd9c1f3295 Co-authored-by: ndyakov <[email protected]>
Copilot
AI
changed the title
[WIP] Fix Vector Set commands to handle RESP2 responses
Fix VectorScoreSliceCmd to handle RESP2 flat array responses
Apr 7, 2026
ofekshenawa
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VectorScoreSliceCmd.readReplycalledrd.ReadMapLen()unconditionally, makingVSimWithScores,VSimWithArgsWithScores, andVLinksWithScoresbroken on RESP2 connections, which return flat arrays instead of maps.Changes
command.go—VectorScoreSliceCmd.readReply: AddPeekReplyType()check before parsing. RESP3 maps use existing path; RESP2 flat arrays ([name, score, ...]) read viaReadArrayLen(), validate even length, then parse pairs sequentially — consistent with howZSliceCmdandXStreamSliceCmdhandle dual-protocol responses.command.go— new constructor: AddNewVectorScoreSliceCmdas the canonical constructor;NewVectorInfoSliceCmdbecomes a backwards-compatible alias.vectorset_commands_test.go: Unit tests forreadReplycovering RESP2 array, RESP3 map, empty responses, and odd-length array error.Note
Medium Risk
Touches Redis reply parsing for vector-with-scores commands; incorrect type detection or length handling could break decoding for some server/protocol combinations, though coverage is added via targeted unit tests.
Overview
Fixes
VectorScoreSliceCmd.readReplyto correctly decode both RESP3 map responses and RESP2 flat array responses ([name, score, ...]), including validation for odd-length RESP2 arrays.Introduces
NewVectorScoreSliceCmdas the canonical constructor and keepsNewVectorInfoSliceCmdas a backwards-compatible alias, and adds unit tests that exercise RESP2/RESP3, empty replies, and error cases.Reviewed by Cursor Bugbot for commit 4491630. Bugbot is set up for automated code reviews on this repo. Configure here.