Sync main with latest release branch #5299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add useSystemThemeListener.ts, it should detect system change References: #RI-7754
* fix(ui): migrate MultiSearch styles to styled-components Migrate MultiSearch component from SCSS modules to styled-components for better theme integration and consistency. References: #RI-7817
* fix(ui): integrate AnalyticsPageHeader in ClusterDetails and SlowLog pages References: #RI-7785
#5266) * fix(api): add proper error messages for invalid cloud database endpoints References: #RI-7778
Bumps [axios](https://github.com/axios/axios) from 1.8.4 to 1.12.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.8.4...v1.12.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.12.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* RI-7744: fix key tests + change e2e trigger temporary * RI-7744: fix keys list tests * RI-7744: fix pub-sub tests * RI-7744: fix add key tests * RI-7744: fix keys list/tree tests * RI-7744: fix keys list full screen tests * RI-7744: fix keys list scroll + streams tests * RI-7744: fix keys list scroll + streams tests * RI-7744: fix dbsize test fix * RI-7744: fix db sorting test * RI-7744: fix navigation tests * RI-7744: fix shortcuts tests * RI-7744: fix confirm popover test * RI-7744: fix db info tooltip * RI-7744: skip pubsub tests * RI-7744: fix search capabilities * RI-7744: fix pub sub tests * RI-7744: fix browser context tests * RI-7744: fix cli helper tests * RI-7744: fix key filter tests * RI-7744: fix key filter 2 tests * RI-7744: fix typo
…e for the keys badges in the browser (#5292) re #RI-7766
|
|
valkirilov
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pawelangelow,
pd-redis and
tptodorov
as code owners
valkirilov
changed the title
valkirilov
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| document.body.removeChild(link) | ||
|
|
||
| // Clean up the blob URL | ||
| URL.revokeObjectURL(blobUrl) |
There was a problem hiding this comment.
Bug: Async function call without await loses error handling
The triggerDownloadFromUrl function was changed from synchronous to async (returning Promise<void>), but its caller in BulkActionsConfig.tsx at line 144 does not await the result or handle the promise. When the download fails (e.g., network error or non-ok response), the throw new Error() at line 19 results in an unhandled promise rejection, silently failing without notifying the user.
ArtemHoruzhenko
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Sync the
mainbranch with thelatestchanges related to the release of v3.0.0.Note
Expose Content-Disposition for bulk report streaming and switch UI download helper to authenticated fetch with Electron window ID and filename handling.
Content-DispositionviaAccess-Control-Expose-HeadersinstreamReport(redisinsight/api/src/modules/bulk-actions/bulk-actions.service.ts) to allow filename retrieval by clients.fetch-basedtriggerDownloadFromUrl(redisinsight/ui/src/utils/dom/triggerDownloadFromUrl.ts):CustomHeaders.WindowIdwhen available (Electron auth).Content-Dispositionand downloads blob.bulk-actions.service.spec.tsto assert exposed header for report downloads.Written by Cursor Bugbot for commit 1e7b922. This will update automatically on new commits. Configure here.