RI-7785 Make Analysis tabs borders and action buttons consitent #5259
+50
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valkirilov
changed the title
valkirilov
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pawelangelow and
pd-redis
as code owners
Contributor
Code Coverage - Frontend unit tests
Test suite run success5474 tests passing in 705 suites. Report generated by 🧪jest coverage report action from 90eae6f |
dantovska
reviewed
Nov 27, 2025
...ight/ui/src/pages/database-analysis/components/analytics-page-header/AnalyticsPageHeader.tsx
Outdated
Show resolved
Hide resolved
pd-redis
reviewed
Nov 28, 2025
| ] | ||
|
|
||
| return ( | ||
| <div className={styles.container} data-testid="cluster-details-header"> |
Contributor
There was a problem hiding this comment.
How about making this styled container? And from styles.module.scss remove the bg color?
| @@ -1,6 +1,5 @@ | |||
| .container { | |||
| background-color: var(--euiColorEmptyShade); | |||
| import { Theme } from 'uiSrc/components/base/theme/types' | ||
|
|
||
| const getBorderColor = (theme: Theme) => | ||
| theme.name === 'dark' ? theme.color.dark600 : theme.color.dusk150 |
Contributor
There was a problem hiding this comment.
no no no no, these are all goiing away. Use semantic color, or you will have to change them next week. There are semantic border colors
Member
Author
There was a problem hiding this comment.
Valid point. I made changes, and now we're hooked onto the semantic variables for the component itself, so we'll depend on it, and we should be in sync with its colors (unless they drop the semantics on a component level 😅).
|
|
||
| export const HeaderContainer = styled.div` | ||
| width: 100%; | ||
| border-bottom: 4px solid |
Contributor
There was a problem hiding this comment.
theme.core.space.space050
valkirilov
force-pushed
the
fe/bugfix/RI-7785/fix-analysis-pages-padding
branch
from
d892a98 to
5760f3c
Compare
Base automatically changed from
fe/bugfix/RI-7785/fix-analysis-pages-padding
to
main
November 28, 2025 14:22
…pages - Replace AnalyticsTabs with the new AnalyticsPageHeader component for improved consistency across pages. - Update styles and layout to enhance visual coherence. References: #RI-7785
- Simplify the AnalyticsPageHeader component by removing the unused children prop. - Update the corresponding type definition to reflect this change. References: #RI-7785
valkirilov
force-pushed
the
fe/bugfix/RI-7785/rework-analysis-layout
branch
from
63d00fb to
6de5a78
Compare
- Introduced a new styled-components file for ClusterDetailsHeader, replacing the previous SCSS styles. - Updated the ClusterDetailsHeader component to utilize the new styled components for improved styling and maintainability. - Removed the old styles module to streamline the codebase. References: #RI-7785
dantovska
approved these changes
Nov 30, 2025
pawelangelow
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactored the Analytics tabs layout (Overview, Database Analysis, Slow Log) to have a consistent appearance across all three pages.
AnalyticsPageHeadercomponent that provides a unified header with tabs and a full-width border that seamlessly aligns with the tabs' active border.Testing
Before
Screen.Recording.2025-11-27.at.15.26.38.mov
After
Screen.Recording.2025-11-27.at.17.05.12.mov
Closes #RI-7785
Note
Refactors
ClusterDetailsHeaderto styled-components and updatesAnalyticsPageHeaderto use theme-based tabs border, removing the unusedchildrenprop.pages/cluster-details/.../ClusterDetailsHeader.tsx:ClusterDetailsHeader.styles.ts); removeclassnames/lodashusage.Container,Content,Item(with$borderLeft) andLoading.AnalyticsPageHeader; simplify tooltip classes.pages/database-analysis/.../AnalyticsPageHeader.styles.ts:border-bottomfrom theme tabs (theme.components.tabs.variants.default.tabsLine).pages/database-analysis/.../AnalyticsPageHeader.tsx&.types.ts:childrensupport; keep optionalactions.styles.module.scssfor cluster details header; minor import removals.Written by Cursor Bugbot for commit 90eae6f. This will update automatically on new commits. Configure here.