(RHEL-133355) encountering ordering cycle triggers segmentation fault#459
Merged
mrc0mmand merged 17 commits intoredhat-plumbers:rhel-8.8.0from Jan 12, 2026
Merged
(RHEL-133355) encountering ordering cycle triggers segmentation fault#459mrc0mmand merged 17 commits intoredhat-plumbers:rhel-8.8.0from
mrc0mmand merged 17 commits intoredhat-plumbers:rhel-8.8.0from
Conversation
The generated string may include %, which will confuse both the xprintf call, and the VA_FORMAT_ADVANCE macro. Pass the generated string as an argument to a "%s" format string instead. (cherry picked from commit 7325a2b) Resolves: RHEL-133355
…string Follow-up for 924775e. The loop run with `STRV_FOREACH_PAIR()`, hence `if (*(unit_id+1))` is not a good way to detect if there exist a next entry. Fixes #26872. (cherry picked from commit 366eced4c81a15a25b9225347fa203aa67798b02) Resolves: RHEL-133355
(cherry picked from commit 999f16514367224cbc50cb3ccc1e4392e43f6811) Related: RHEL-133355
As we ignores the failure in merge_unit_ids(), so unit_ids may be NULL. (cherry picked from commit 5803c24da5cf543a55c4fce9009a9c5f2b18519a) Related: RHEL-133355
This is trivially exploitable (in the sense of causing a crash from SEGV) e.g.
by 'shutdown now "Message %s %s %n"'. The message is settable through polkit,
but is limited to auth_admin:
<action id="org.freedesktop.login1.set-wall-message">
<description gettext-domain="systemd">Set a wall message</description>
<message gettext-domain="systemd">Authentication is required to set a wall message</message>
<defaults>
<allow_any>auth_admin_keep</allow_any>
<allow_inactive>auth_admin_keep</allow_inactive>
<allow_active>auth_admin_keep</allow_active>
</defaults>
</action>
Bug introduced in 9ef1502
('logind/systemctl: introduce SetWallMessage and --message', 2015-09-15).
(cherry picked from commit 0cb09bc)
Related: RHEL-133355
tcornell-bus
changed the title
github-actions
bot
added
rhel-8.8.0
pr/needs-ci
Commit validationTracker - RHEL-133458 The following commits meet all requirements
Tracker validationSuccess🟢 Tracker RHEL-133458 has set desired product: Pull Request validationSuccess🟡 CI - Waived Auto MergeFailed🔴 Pull Request has unsupported target branch Success🟢 Pull Request is not marked as draft and it's not blocked by |
Member
|
All current CI fails are expected:
@tcornell-bus could you, please, backport at least the last two patches for GH Actions, as they're quite easy to backport? I'll leave the decision whether to backport the first two patch sets on you, since they're quite substantial (compared to the rest). |
`v3` will be deprecated soon, so update to `v4`. https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ rhel-only Related: RHEL-133355
Temporarily point repos in C8S containers to the Vault (since C8S is EOL), until we figure out a _proper_ solution. rhel-only Related: RHEL-133355
The expect stuff was anything but expected, so let's just backport the upstream test case and tweak it a bit to account for the missing parts in our downstream testing infrastructure. Follow-up to 638c241. Related: RHEL-133355 rhel-only
Signed-off-by: Luís Ferreira <contact@lsferreira.net> (cherry picked from commit ccf4784) Related: RHEL-133355
(cherry picked from commit 331e34f) Related: RHEL-133355
Loosely cherry-picked from aa549ff. rhel-only Related: RHEL-133355
(cherry picked from commit ad0d9c0) Related: RHEL-133355
In the past we didn't have any matches like that, so the parser was stricter than necessary, but now we have, so allow that. (cherry picked from commit 457763a) Related: RHEL-133355
pyparsing 2.3.1/2.4.0 had some changes to grouping of And matches, and as a result we'd report 0 properties and 0 matches, and not really do any checks. With this change we get identical behaviour for pyparsing 2.3.1, 2.4.0, 2.4.2: $ hwdb/parse_hwdb.py hwdb/60-evdev.hwdb: 72 match groups, 94 matches, 262 properties hwdb/60-input-id.hwdb: 3 match groups, 3 matches, 4 properties hwdb/60-keyboard.hwdb: 173 match groups, 256 matches, 872 properties Keycode KBD_LCD_MENU1 unknown Keycode KBD_LCD_MENU4 unknown Keycode KBD_LCD_MENU2 unknown Keycode KBD_LCD_MENU3 unknown hwdb/60-sensor.hwdb: 101 match groups, 120 matches, 105 properties hwdb/70-joystick.hwdb: 2 match groups, 3 matches, 2 properties hwdb/70-mouse.hwdb: 104 match groups, 119 matches, 123 properties hwdb/70-pointingstick.hwdb: 8 match groups, 30 matches, 11 properties hwdb/70-touchpad.hwdb: 6 match groups, 9 matches, 6 properties (cherry picked from commit 2382a2e) Related: RHEL-133355
tcornell-bus
force-pushed
the
RHEL-133355
branch
from
08e382e to
6cd30fd
Compare
Member
…DUMPED Depending on system configuration and whether SCMP_ACT_KILL_PROCESS or SCMP_ACT_KILL_THREAD is available/used processes might coredump on specific coredumps or are just plain killed. For our test case the difference doesn't really matter, hence let's hide it away. (cherry picked from commit c3ab2c3) Related: RHEL-133355
These services are likely to coredump, and we expect that but aren't interested in the coredump. Hence let's turn off processing by setting RLIMIT_CORE to 0/0. (cherry picked from commit a429223) Related: RHEL-133355
github-actions
bot
added
pr/needs-manual-merge
and removed
pr/needs-ci
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport RHEL-8.10 RHEL-132317 first PR:
The generated string may include %, which will confuse both the xprintf call, and the VA_FORMAT_ADVANCE macro.
Pass the generated string as an argument to a "%s" format string instead.
(cherry picked from commit 7325a2b)
Resolves: RHEL-133355
Backport RHEL-8.10 RHEL-132317 second PR:
This is trivially exploitable (in the sense of causing a crash from SEGV) e.g. by 'shutdown now "Message %s %s %n"'. The message is settable through polkit, but is limited to auth_admin:
Bug introduced in 9ef1502 ('logind/systemctl: introduce SetWallMessage and --message', 2015-09-15).
(cherry picked from commit 0cb09bc)
Related: RHEL-133355
Fix CI issues by backporting PRs referenced in comment1 and comment2. I left out this commit, since it is removing an unused variable from a file that does not exist in the rhel-8.8.0 branch.