(#2179309) test: make TEST-35-LOGIN stable again#374
Merged
systemd-rhel-bot merged 1 commit intoredhat-plumbers:mainfrom Mar 30, 2023
Merged
(#2179309) test: make TEST-35-LOGIN stable again#374systemd-rhel-bot merged 1 commit intoredhat-plumbers:mainfrom
systemd-rhel-bot merged 1 commit intoredhat-plumbers:mainfrom
Conversation
systemd-rhel-bot
changed the title
mrc0mmand
force-pushed
the
TEST-35-tweaks
branch
from
8d7d806 to
a60640f
Compare
Member
Author
|
Welp, CI definitely disagrees. The search goes on then... |
dtardon
previously approved these changes
Mar 30, 2023
Member
dtardon
left a comment
dtardon
left a comment
There was a problem hiding this comment.
Anything that makes the test more reliable is good.
LGTM
Member
|
Btw, maybe you could take inspiration from systemd/systemd#27038 and use a fifo for synchronization with the expect process instead of a busy loop? |
The expect stuff was anything but expected, so let's just backport the upstream test case and tweak it a bit to account for the missing parts in our downstream testing infrastructure. Follow-up to 638c241. Related: #2179309 rhel-only
mrc0mmand
force-pushed
the
TEST-35-tweaks
branch
from
a60640f to
9050fb2
Compare
Member
Author
|
Okay, so I gave up on the expect stuff, since it did everything but what I'd expect, and decided to just backport the latest version of the test from the upstream. After tweaking it a little, to account for missing stuff in downstream, it seems to be pretty stable (at least it keeps passing locally when I run it in a loop). Let's see what the CI is going to say. |
Member
|
LGTM and CI is finally green 🥳 |
msekletar
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's add a couple of synchronization points and reduce the amount of sleeps to make the test, hopefully, stable again.
Follow-up to 638c241.
Related: #2179309
rhel-only
Let's see if the CI agrees, locally the test appeared quite stable once again.