Fix Windows 11 taskbar icon not showing#14905
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Windows resource scripts for the RealSense viewer tools so GLFW can locate the application icon resource on Windows 11 (preventing the taskbar from showing the generic icon), and re-encodes the depth-quality .rc for readability.
Changes:
- Add a
GLFW_ICONicon resource pointing toicon.icoforrealsense-viewer. - Replace the
rs-depth-qualityresource script content (intended UTF-16 → UTF-8 conversion) and addGLFW_ICONthere as well.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/realsense-viewer/res/realsense-viewer.rc | Adds GLFW_ICON resource to support GLFW’s Win32 icon loading for taskbar/class icon. |
| tools/depth-quality/res/realsense-viewer.rc | Rewrites the resource script (encoding conversion) and adds GLFW_ICON, but introduces malformed line endings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nir-Az
commented
Apr 5, 2026
| @@ -0,0 +1,130 @@ | |||
| // Microsoft Visual C++ generated resource script. | |||
Collaborator
Author
There was a problem hiding this comment.
This was converted from the binary representation that was checked in before.
realsense-viewer was text based and depth quality was binary.
Only change is the icon line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GLFW_ICONnamed resource to.rcfiles so GLFW finds the app icon when registering the window class. Without it, Windows 11 taskbar falls back to the generic icon..rcfrom UTF-16 to UTF-8 for readability.Before:
After:
🤖 Generated with Claude Code