Avoid out-of-bounds access on global data

[torstenbaer]

The issue can be easily seen with the address sanitizer. 'realsense_udev_rules' is a generated char[] that is not NUL-terminated. Assigning to a std::string involves a strlen() call. Obviously, that call cannot find the NUL in the char array and thus accesses at least one byte outside of that buffer.

We could alternatively ensure that the generated buffer is NUL-terminated (not sure, whether there are other such generated char arrays), or we could provide the actual length to the constructor.

I have chosen the latter one here, because it avoids the strlen() call (roughly 10KB to scan).

This fixes the issue 14356.

[sysrsbuild]

Can one of the admins verify this patch?

[Copilot]

Pull Request Overview

This PR ensures construction of a std::string from a non-NUL-terminated generated char array without invoking strlen, preventing out-of-bounds reads and eliminating an unnecessary 10KB scan.

• Replace implicit C-string constructor (which called strlen) with length-aware constructor using sizeof.
• Add an explanatory comment about lack of NUL termination.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[OhadMeir]

@torstenbaer thank you for the contribution.

An internal ticket have been created to add automatic address sanitizer checks for viewer code, currently only SDK is checked.