Simplify boxing + add tostring overloads for test case data #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaPeste
approved these changes
Feb 4, 2021
Contributor
LaPeste
left a comment
LaPeste
left a comment
There was a problem hiding this comment.
Using the Activator is a sleek improvement.
LaPeste
added a commit
that referenced
this pull request
Feb 24, 2021
* core updated to have new bison parser * Wrong commit used for core * New query was not applied on top of the previous one * PR feedback applied * Forgot a null check * Updated unit test to match changed in error message * Updated changelog * Revert "Updated changelog" This reverts commit 89ae7f5. * Updated changelog, again * Fallback to original ordering if the new query doesn't have one * Fixed usage of query odering * Updated unit test to use the user facing name of class * Changed realm-core to have new changes * Core points to new commit * Updated changelog * Update CHANGELOG.md Co-authored-by: Nikola Irinchev <[email protected]> * Update core submodule and added std::move * Added value substitution in string based query * All types have a unit test for string based search * Changelog updated * Added object store to gitignore and set lf as ending line in code style rules * Changed style of object instantiation in array * Added unit test for in memory object in string based query * Renamed tests to be more coherent with the chosen style * Improved some code style * Added comment to explain PrimitiveValue <--> realm_value_t relationship * Renamed a var * Fixed changelog and gitignore * Applied feedback from PR * Applied general feedback from PR * Reshaped tests and added more * Point to right core and updated DictionaryHandle to respect signature of GetFilteredResults * Some renaming * Fixed changelog * Some of the PR feedback applied * Simplified tests and added test for embedded objects and extended embedded obj to have Guid, ObjectId and byte[] * Added RealmInteger tests for string query value sustitution * Forgot to rethrow properly * Test nullable null value correctly passed to core in query string value substitution * Small style fixes * Simplify boxing + add tostring overloads for test case data (#2228) * Reverted to correct core submodule to be equal to master * Fixed documentation for the Filter method * Updated realm-core to fix unit test Co-authored-by: Nikola Irinchev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.