Add support for value substitution in string based queries #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89ae7f5.
Co-authored-by: Nikola Irinchev <[email protected]>
nirinchev
reviewed
Feb 1, 2021
Member
nirinchev
left a comment
nirinchev
left a comment
There was a problem hiding this comment.
Some final comments mostly related to tests/simplifying the conversion logic as that was quite hard to grasp/follow. In addition to that, some extra tests you might want to add:
- Tests for object matches that use embedded objects. You can use
ObjectWithEmbeddedPropertiesandEmbeddedAllTypesObject. Then, the tests should verify that this works:realm.All<ObjectWithEmbeddedProperties>().Filter("AllTypesObject = $0", theEmbedded) - Test that
nullis passed correctly as a value. e.g.realm.All<Foo>().Filter("Prop = null")should be equivalent byrealm.All<Foo>().Filter("Prop = $0", (int?)null)(assumingPropisint?). Note that you need the explicit cast as implicit null casts don't work yet and may not work due to reasons @papafe will explain on Wednesday.
…edded obj to have Guid, ObjectId and byte[]
LaPeste
commented
Feb 4, 2021
nirinchev
reviewed
Feb 12, 2021
| /// var results1 = realm.All<Foo>("Bar.IntValue > 0"); | ||
| /// var results2 = realm.All<Foo>("Bar.IntValue > 0 SORT(Bar.IntValue ASC Bar.StringValue DESC)"); | ||
| /// var results3 = realm.All<Foo>("Bar.IntValue > 0 SORT(Bar.IntValue ASC Bar.StringValue DESC) DISTINCT(Bar.IntValue)"); | ||
| /// var results4 = realm.All<Foo>("Bar.IntValue > $0 || (Bar.String == $1 && Bar.Bool == $2)" 5, "small", true"); |
Member
There was a problem hiding this comment.
Suggested change
| /// var results4 = realm.All<Foo>("Bar.IntValue > $0 || (Bar.String == $1 && Bar.Bool == $2)" 5, "small", true"); | |
| /// var results4 = realm.All<Foo>("Bar.IntValue > $0 || (Bar.String == $1 && Bar.Bool == $2)", 5, "small", true); |
Contributor
Author
There was a problem hiding this comment.
How is this posted only now? I do remember not seeing the suggestion after the talk in the call. Anyway, it's already fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for value substitution meant updating the wrapper to supply an array of mixed value to core. And from the C# side passing a marshable array of PrimitiveValue to the wrappers.
Documentation for the syntax of value substitution can be found here.
Fixes #1822
TODO
Nothing left
=============================
UPDATE:
RealmValueType.Nullto core when an in-memory object is supplied. This will need to be corrected, but not by this PR.