Skip to content

fix(entropy)!: use enum for resource status and change UpdateResourceRequest to include only urn and configs. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravisuhag merged 1 commit into from
Feb 2, 2022
Merged

fix(entropy)!: use enum for resource status and change UpdateResourceRequest to include only urn and configs. #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions odpf/entropy/v1beta1/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ syntax = "proto3";
package odpf.entropy.v1beta1;

import "google/api/annotations.proto";
import "google/protobuf/field_mask.proto";
import "google/protobuf/struct.proto";
import "google/protobuf/timestamp.proto";

Expand Down Expand Up @@ -35,8 +34,8 @@ service ResourceService {

rpc UpdateResource(UpdateResourceRequest) returns (UpdateResourceResponse) {
option (google.api.http) = {
patch: "/v1beta1/resources/{resource.urn}"
body: "resource"
patch: "/v1beta1/resources/{urn}"
body: "*"
};
}

Expand All @@ -54,7 +53,16 @@ message Resource {
string kind = 4;
google.protobuf.Value configs = 5;
map<string, string> labels = 6;
string status = 7;

enum Status {
STATUS_UNSPECIFIED = 0;
STATUS_PENDING = 1;
STATUS_ERROR = 2;
STATUS_RUNNING = 3;
STATUS_STOPPED = 4;
STATUS_COMPLETED = 5;
}
Status status = 7;
google.protobuf.Timestamp created_at = 8;
google.protobuf.Timestamp updated_at = 9;
}
Expand Down Expand Up @@ -85,8 +93,8 @@ message CreateResourceResponse {
}

message UpdateResourceRequest {
Resource resource = 1;
google.protobuf.FieldMask update_mask = 2;
string urn = 1;
google.protobuf.Value configs = 2;
}

message UpdateResourceResponse {
Expand Down