Skip to content

fix(entropy)!: use enum for resource status and change UpdateResourceRequest to include only urn and configs. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ravisuhag merged 1 commit into from
Feb 2, 2022
Merged

fix(entropy)!: use enum for resource status and change UpdateResourceRequest to include only urn and configs. #97

ravisuhag merged 1 commit into from
Feb 2, 2022

Conversation

@rohilsurana
Copy link
Member

@rohilsurana rohilsurana commented Feb 2, 2022

BREAKING CHANGE:

  • make Resource.status an enum type.
  • Remove resource from UpdateResourceRequest and add urn and configs only.

@rohilsurana
Copy link
Member Author

rohilsurana commented Feb 2, 2022

Breaking CI workflows can be ignored as the commit includes breaking changes on recently merged protobuf definition.

@ravisuhag ravisuhag merged commit 45da924 into raystack:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija

@pyadav pyadav Awaiting requested review from pyadav

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohilsurana @ravisuhag