feat: add caramlstore extractor #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
force-pushed
the
caramlstore-extractor
branch
2 times, most recently
from
e561f8d to
91fc028
Compare
sudo-suhas
force-pushed
the
caramlstore-extractor
branch
from
91fc028 to
3e36929
Compare
Contributor
Author
|
Coverage dropped from 83% on main to 76% because |
This was referenced Oct 6, 2022
sudo-suhas
force-pushed
the
caramlstore-extractor
branch
from
3e36929 to
134674e
Compare
- Bump proton commit for code generation. Pull in the asset model for
- MLFeatureTable
- Service
- Experiment
- Metric
- MLModel
- Implement the machine learning feature tables extractor for CaraML
store.
- Add the gRPC client generated from CaraML store's CoreService. See
https://github.com/caraml-dev/caraml-store/blob/v0.1.1/caraml-store-protobuf/src/main/proto/feast/core/CoreService.proto#L12.
- Register the extractor in plugins/extractors/populate.go.
- Add the extractor to the list in docs/reference/extractor.md.
- Extend config parser to support parsing
- time duration in string format such as '30s'.
- CSV as a string array. ex: 'comma,separated,value'.
- Integrate github.com/vektra/mockery for mock generation.
- Rewrite links in extractors docs to use relative paths. This works
in IDEs and editors without needing to open a web page.
- Add 't.Helper()' annotations for test helper methods. This helps with
error reporting the test function line instead of helper in case of
an error.
- Add hlper method for extracting the gRPC status code from a wrapped
error. The methods provided by gRPC library do not support extracting
the status code from an error wrapped with additional context.
- Add test helper method LoadJSONIntoProto.
- Remove unused function BuildConfig from utils/config.go.
- Refactor usage of deprecated ioutil package using os and io packages.
sudo-suhas
force-pushed
the
caramlstore-extractor
branch
from
134674e to
4b73336
Compare
StewartJingga
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Ownership for extracted assets.not requiredCloses #73