Skip to content

feat: allow feature_table as an asset type #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sudo-suhas merged 1 commit into from
Oct 27, 2022
Merged

feat: allow feature_table as an asset type #176

sudo-suhas merged 1 commit into from
Oct 27, 2022

Conversation

@sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Oct 6, 2022 •
edited
Loading

Related to raystack/meteor#417

@sudo-suhas sudo-suhas force-pushed the type-ml_feature_table branch from f270d45 to f1ae11e Compare October 6, 2022 11:07
@coveralls
Copy link

coveralls commented Oct 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3262550248

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.115%
Totals Coverage Status
Change from base Build 3225140857: 0.0%
Covered Lines: 4887
Relevant Lines: 5675
💛 - Coveralls

@StewartJingga
Copy link
Contributor

StewartJingga commented Oct 11, 2022

LGTM, just a small concern if ml_feature_table is a good type name? cc: @sudo-suhas @ravisuhag

@sudo-suhas
Copy link
Contributor Author

sudo-suhas commented Oct 11, 2022

Do you have a suggestion @StewartJingga? In the PR for adding E2E lineage entities (raystack/proton#193), we had discussed calling it FeatureTable instead of MLFeatureTable but chose to keep it as MLFeatureTable because 'Feature' is an overloaded word that is not clear enough.

@sudo-suhas sudo-suhas force-pushed the type-ml_feature_table branch from f1ae11e to af851a9 Compare October 17, 2022 05:10
@sudo-suhas sudo-suhas force-pushed the type-ml_feature_table branch from af851a9 to ebf6738 Compare October 17, 2022 05:14
@sudo-suhas sudo-suhas changed the title feat: allow ml_feature_table as an asset type feat: allow feature_table as an asset type Oct 17, 2022
StewartJingga
StewartJingga approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudo-suhas sudo-suhas merged commit b18d570 into main Oct 27, 2022
@sudo-suhas sudo-suhas deleted the type-ml_feature_table branch October 27, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sudo-suhas @coveralls @StewartJingga