feat: add shield sink #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ishanarya0
force-pushed
the
shield-sink
branch
from
6c95fcc to
e0d7f46
Compare
sudo-suhas
requested changes
Sep 12, 2022
sudo-suhas
requested changes
Sep 14, 2022
Contributor
sudo-suhas
left a comment
sudo-suhas
left a comment
There was a problem hiding this comment.
Apologies for missing some of the comments in the previous review
StewartJingga
requested changes
Sep 15, 2022
ishanarya0
force-pushed
the
shield-sink
branch
from
0efba4a to
61bae92
Compare
StewartJingga
requested changes
Sep 19, 2022
Contributor
StewartJingga
left a comment
StewartJingga
left a comment
There was a problem hiding this comment.
Need help updating this docs as well 🙏
https://github.com/odpf/meteor/blob/main/docs/docs/reference/sinks.md#sinks
Member
|
@ishanarya0 CI is failing because of code coverage. Can you check this? |
StewartJingga
requested changes
Sep 26, 2022
StewartJingga
requested changes
Sep 27, 2022
StewartJingga
requested changes
Oct 28, 2022
StewartJingga
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.