fix(gen): format, fix sample configs used for generating recipes #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@StewartJingga this issue is present in #408 as well. Can we review and merge this change? |
- Introduce and use template helper function on sample configs of
sinks, extractors and processors to replace tabs, if present, with
spaces in sample configs. If tabs are present, parsing the file as
YAML fails.
- Fix sample configs for sinks/http, extractors/{kafka, tableau}.
- Reformat sample configs for consistency.
sudo-suhas
force-pushed
the
fix-sample-configs
branch
from
8a1583c to
eb956cf
Compare
ravisuhag
reviewed
Sep 13, 2022
| return pad + strings.Replace(v, "\n", "\n"+pad, -1) | ||
| } | ||
|
|
||
| func fmtSampleConfig(s string) string { |
Member
There was a problem hiding this comment.
@sudo-suhas lets rename this to something short? maybe cfmt ?
Contributor
Author
There was a problem hiding this comment.
Does rawfmt work?
Contributor
|
Should we move sample config to its own file 🤔 ? or even better, maybe we should generate sample config from the |
Contributor
We can keep current change for now, need more analysis and effort for generating from |
StewartJingga
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinks, extractors and processors to replace tabs, if present, with
spaces in sample configs. If tabs are present, parsing the file as
YAML fails.