Skip to content

feat!: modify URN format to follow ODPF standard #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StewartJingga merged 10 commits into from
Aug 2, 2022
Merged

feat!: modify URN format to follow ODPF standard #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ce37974
feat: add base plugin
StewartJingga Jul 26, 2022
7f1796e
fix: breaking plugin test
StewartJingga Jul 26, 2022
a42ec9c
fix: lint errors
StewartJingga Jul 26, 2022
19c4d23
feat: create a NewURN function
StewartJingga Jul 26, 2022
0452a8a
test: add missing tests
StewartJingga Jul 26, 2022
9d2cfe4
feat: update all extractors to use odpf urn
StewartJingga Jul 28, 2022
9fefa53
feat(plugins): add BaseExtractor
StewartJingga Jul 29, 2022
8fef475
fix: breaking test
StewartJingga Jul 29, 2022
f3e4182
fix: improve test coverage
StewartJingga Jul 29, 2022
dcc9e48
fix: config not passed properly
StewartJingga Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ func (r *Agent) Validate(rcp recipe.Recipe) (errs []error) {
if ext, err := r.extractorFactory.Get(rcp.Source.Name); err != nil {
errs = append(errs, err)
} else {
if err = ext.Validate(rcp.Source.Config); err != nil {
if err = ext.Validate(plugins.Config{
URNScope: rcp.Source.Scope,
RawConfig: rcp.Source.Config,
}); err != nil {
errs = append(errs, r.enrichInvalidConfigError(err, rcp.Source.Name, plugins.PluginTypeExtractor))
}
}
Expand All @@ -72,7 +75,7 @@ func (r *Agent) Validate(rcp recipe.Recipe) (errs []error) {
errs = append(errs, err)
continue
}
if err = sink.Validate(s.Config); err != nil {
if err = sink.Validate(plugins.Config{RawConfig: s.Config}); err != nil {
errs = append(errs, r.enrichInvalidConfigError(err, s.Name, plugins.PluginTypeSink))
}
}
Expand All @@ -83,7 +86,7 @@ func (r *Agent) Validate(rcp recipe.Recipe) (errs []error) {
errs = append(errs, err)
continue
}
if err = procc.Validate(p.Config); err != nil {
if err = procc.Validate(plugins.Config{RawConfig: p.Config}); err != nil {
errs = append(errs, r.enrichInvalidConfigError(err, p.Name, plugins.PluginTypeProcessor))
}
}
Expand Down Expand Up @@ -197,7 +200,7 @@ func (r *Agent) setupExtractor(ctx context.Context, sr recipe.PluginRecipe, str
err = errors.Wrapf(err, "could not find extractor \"%s\"", sr.Name)
return
}
if err = extractor.Init(ctx, sr.Config); err != nil {
if err = extractor.Init(ctx, recipeToPluginConfig(sr)); err != nil {
err = errors.Wrapf(err, "could not initiate extractor \"%s\"", sr.Name)
return
}
Expand All @@ -217,7 +220,7 @@ func (r *Agent) setupProcessor(ctx context.Context, pr recipe.PluginRecipe, str
if proc, err = r.processorFactory.Get(pr.Name); err != nil {
return errors.Wrapf(err, "could not find processor \"%s\"", pr.Name)
}
if err = proc.Init(ctx, pr.Config); err != nil {
if err = proc.Init(ctx, recipeToPluginConfig(pr)); err != nil {
return errors.Wrapf(err, "could not initiate processor \"%s\"", pr.Name)
}

Expand All @@ -240,7 +243,7 @@ func (r *Agent) setupSink(ctx context.Context, sr recipe.PluginRecipe, stream *s
if sink, err = r.sinkFactory.Get(sr.Name); err != nil {
return errors.Wrapf(err, "could not find sink \"%s\"", sr.Name)
}
if err = sink.Init(ctx, sr.Config); err != nil {
if err = sink.Init(ctx, recipeToPluginConfig(sr)); err != nil {
return errors.Wrapf(err, "could not initiate sink \"%s\"", sr.Name)
}
retryNotification := func(e error, d time.Duration) {
Expand Down
Loading