Skip to content

feat!: modify URN format to follow ODPF standard #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StewartJingga merged 10 commits into from
Aug 2, 2022
Merged

feat!: modify URN format to follow ODPF standard #387

StewartJingga merged 10 commits into from
Aug 2, 2022

Conversation

@StewartJingga
Copy link
Contributor

@StewartJingga StewartJingga commented Jul 26, 2022 •
edited
Loading

  • Add new BasePlugin (all plugins will inherit from this)
  • New URN generator
  • Update all extractors to use the new URN generator

@StewartJingga StewartJingga added the enhancement New feature or request label Jul 26, 2022
@StewartJingga StewartJingga self-assigned this Jul 26, 2022
@StewartJingga StewartJingga changed the title feat: add base plugin feat!: modify URN format to follow ODPF standard Jul 28, 2022
@StewartJingga StewartJingga linked an issue Jul 28, 2022 that may be closed by this pull request
feat: use ODPF standard for URN format #388
Closed
@StewartJingga StewartJingga marked this pull request as ready for review July 28, 2022 22:16
@StewartJingga StewartJingga merged commit d5ba47c into main Aug 2, 2022
@StewartJingga StewartJingga deleted the odpf-urn branch August 2, 2022 18:09
@StewartJingga StewartJingga mentioned this pull request Aug 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohilsurana rohilsurana rohilsurana approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

@scortier scortier Awaiting requested review from scortier

Assignees

@StewartJingga StewartJingga

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: use ODPF standard for URN format

3 participants

@StewartJingga @rohilsurana