Advertise NumPy 2 support and test against numba==0.57 and numpy==1.23#1612
Closed
seberg wants to merge 4 commits intorapidsai:branch-24.08from
Closed
Advertise NumPy 2 support and test against numba==0.57 and numpy==1.23#1612seberg wants to merge 4 commits intorapidsai:branch-24.08from
seberg wants to merge 4 commits intorapidsai:branch-24.08from
Conversation
Since the dependency is very light, assume that <3 is fine here.
14 tasks
Contributor
Author
|
Closing, going to continue on original PR. |
Contributor
Author
|
Sorry for the noise, will continue here after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is mostly gh-1606, but continues it:
It then uses this to enforce that we run tests with
numba==0.57andnumpy==1.23so that tests are not only run with NumPy 2 when bumping.This is not particularly important for RMM, but interesting for other RAPIDS libraries.
Planned changes:
earliest, I would like to rename it tooldest, but I cannot without creating a branch in the shared workflow (I think).numpy<3as a pin. We could also use a rule likecurrent+2throughout RAPIDS.Checklist