WIP: Bump fmt (to 10.2.1) and spdlog (to 1.13), remove patches

[jameslamb]

Description

Contributes to:

• Treat clobber warnings as errors for conda builds build-planning#54
• update fmt and spdlog across RAPIDS build-planning#56
• [FEA] rapids_cpm_spdlog generate correct build config support #387

Makes the following direct changes to cpm/versions.json

• bumps fmt (10.1.1 -> 10.2.1), removes patches
• bumps spdlog (1.12.0 -> 1.13.0), removes patches

Which led to the following supporting changes:

• modifies pinning tests from rapids-cmake can generate pinned versions file #530:
  • to only test projects that were downloaded by CPM (e.g. ignoring the fmt that already exists in the build environment)
  • to echo out pinned_versions.json and versions.json in logs from failed tests, to make debugging faster

Notes for Reviewers

Just opening this to test. Will fill this out more when it's ready for review.

Related:

• Provide spdlog_header_only in build directory export gabime/spdlog#2846
• Ensure consistent spdlog dependency target no matter the source rmm#1101

How I tested this

Pushed a commit with the new test error message content changes but keeping fmt in the failing tests, to confirm that the expected tests failed.

got the expected outputs (click me)

The following tests FAILED:
	698 - cpm_generate_pins-nested-makefile (Failed)
	700 - cpm_generate_pins-nested-ninja (Failed)
	702 - cpm_generate_pins-nested-ninja_multi-config (Failed)
	722 - cpm_generate_pins-simple-makefile (Failed)
	724 - cpm_generate_pins-simple-ninja (Failed)
	726 - cpm_generate_pins-simple-ninja_multi-config (Failed)

And they failed in the expected way more informative logs!

CMake Error at CMakeLists.txt:51 (message):
  pinned fmt tag (10.2.1) should differ compared to baseline 10.2.1

  pinned_versions.json:

  {

    "always_download" : true,
    "git_shallow" : false,
    "git_tag" : "${version}",
    "git_url" : "https://github.com/fmtlib/fmt.git",
    "version" : "10.2.1"

  }

  versions.json:

  {

    "git_tag" : "${version}",
    "git_url" : "https://github.com/fmtlib/fmt.git",
    "version" : "10.2.1"

  }

(build link)

Opened PRs on a few repos, pointed at this rapids-cmake branch using the approach described in the rapids-cmake docs (link).

I also modified each of those PRs so that their conda builds and tests consumed CI artifacts from the other PRs. Following this example: rapidsai/cuml#5640.

• ✅ rmm (WIP: update fmt (>=10.2.1) and spdlog (>=1.13) rmm#1544)
• ✅ cudf (WIP: update fmt (>=10.2.1) and spdlog (>=1.13) cudf#15603)
  • just the conda devcontainers build failing, because it couldn't find the conda packages from rmm's CI
• ⚠️ raft (WIP: update fmt (>=10.2.1) and spdlog (>=1.13) raft#2279)
  • builds all passing, CUDA 12.x conda tests failing with a possibly-unrelated issue: WIP: update fmt (>=10.2.1) and spdlog (>=1.13) raft#2279 (comment)
• ⏳ cuml (WIP: update fmt (>=10.2.1) and spdlog (>=1.13) cuml#5870)

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.
• The cmake-format.json is up to date with these changes.
• I have added new files under rapids-cmake/
  • I have added include guards (include_guard(GLOBAL))
  • I have added the associated docs/ rst file and update the api.rst

[jameslamb]

I chose not to add validation here that projects-to-verify is non-empty. That already happens in the verify/ scripts.

e.g.

rapids-cmake/testing/cpm/cpm_generate_pins-nested/verify/CMakeLists.txt

Lines 25 to 28 in e1fbcd9

	string(REPLACE " " ";" projects-to-verify "${projects-to-verify}")
	if(NOT projects-to-verify)
	message(FATAL_ERROR "Failed to pass anything in projects-to-verify")
	endif()

[jameslamb]

This work is paused, in favor of pursuing a better long-term solution in the future. Closing this PR for now.

Subscribe to rapidsai/build-planning#54 and rapidsai/build-planning#56 for updates.