WIP: update fmt (>=10.2.1) and spdlog (>=1.13)#15603
Closed
jameslamb wants to merge 4 commits intorapidsai:branch-24.08from
jameslamb:update-fmt-and-spdlog
Closed
WIP: update fmt (>=10.2.1) and spdlog (>=1.13)#15603jameslamb wants to merge 4 commits intorapidsai:branch-24.08from jameslamb:update-fmt-and-spdlog
jameslamb wants to merge 4 commits intorapidsai:branch-24.08from
jameslamb:update-fmt-and-spdlog
Conversation
jameslamb
added
2 - In Progress
github-actions
bot
added
libcudf
7 tasks
Member
Author
|
This work is paused, in favor of pursuing a better long-term solution in the future. Closing this PR for now. Subscribe to rapidsai/build-planning#54 and rapidsai/build-planning#56 for updates. |
AyodeAwe
pushed a commit
that referenced
this pull request
Sep 23, 2024
## Description Replaces #15603 Contributes to: * rapidsai/build-planning#54 * rapidsai/build-planning#56 * rapidsai/rapids-cmake#387 Now that most of `conda-forge` has been updated to `fmt >=11.0.1,<12` and `spdlog>=1.14.1,<1.15` (rapidsai/build-planning#56 (comment)), we're attempting to upgrade RAPIDS to similar versions of those libraries. This improves the likelihood that RAPIDS will be installable alongside newer versions of its dependencies and complementary packages on conda-forge. ## Notes for Reviewers This PR is testing changes made in rapidsai/rapids-cmake#689. It shouldn't be merged until those `rapids-cmake` changes are merged and any testing-specific details have been removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contributes to:
fmtandspdlogacross RAPIDS build-planning#56Testing with:
fmt(to 10.2.1) andspdlog(to 1.13), remove patches rapids-cmake#592Notes for Reviewers
Will put up a better description and revert testing-only changes before marking this ready for review.
Testing with an approach similar to rapidsai/cuml#5640
Checklist