Conditionally include hnsw wrapper source in CMake#2135
Merged
raydouglass merged 1 commit intorapidsai:branch-24.02from Jan 29, 2024
Merged
Conditionally include hnsw wrapper source in CMake#2135raydouglass merged 1 commit intorapidsai:branch-24.02from
hnsw wrapper source in CMake#2135raydouglass merged 1 commit intorapidsai:branch-24.02from
Conversation
cjnolet
approved these changes
Jan 27, 2024
bdice
approved these changes
Jan 27, 2024
3 tasks
robertmaynard
approved these changes
Jan 29, 2024
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
This PR conditionally includes `hnsw` sources, to prevent build errors like those seen in cuGraph after rapidsai#2022 was merged. See also: rapidsai/cugraph#4121, rapidsai/cugraph#4122 Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Bradley Dice (https://github.com/bdice) - Robert Maynard (https://github.com/robertmaynard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR conditionally includes
hnswsources, to prevent build errors like those seen in cuGraph after #2022 was merged. See also: rapidsai/cugraph#4121, rapidsai/cugraph#4122