handle more RAPIDS version formats in update-version.sh, refactor dependencies.yaml#4109
handle more RAPIDS version formats in update-version.sh, refactor dependencies.yaml#4109rapids-bot[bot] merged 12 commits intorapidsai:branch-24.04from jameslamb:update-version
Conversation
bdice
left a comment
There was a problem hiding this comment.
Approving with one small suggestion.
|
This CI failure: Should hopefully be fixed by rapidsai/raft#2135 |
|
I just pulled latest |
|
ah looks like @jakirkham noticed the same thing on #4127. Let's get that one passing and merged first, then update this one. |
rlratzel
left a comment
There was a problem hiding this comment.
LGTM, although I didn't verify the regexes in the sed calls work so I'm assuming that was tested.
That PR is now merged. So we should be good to update here |
|
Thanks @jakirkham , I've updated this to the latest |
|
Thanks James! 🙏 Looks like we are seeing some test failures with CUDA 12 wheels. Not sure if they are related to this change |
|
I think the Python test failures could be related to pandas 2 changes in cudf. There are lots of separate failure cases. |
|
Python failures should be fixed when #4144 merges |
|
/merge |
Description
Contributes to rapidsai/build-planning#13.
Updates
update-version.shto correctly handle RAPIDS dependencies likecudf-cu12==24.2.*.This also pulls in some dependency refactoring originally added in #4088, which allows greater use of dependencies.yaml globs (and therefore less maintenance effort to support new CUDA versions).
Checklist
How I tested this
The portability of this updated
sedcommand was tested here: rapidsai/cudf#14825 (comment).In this repo, I ran the following:
Confirmed that that first
git diffchanged all the things I expected, and that second one showed 0 changes.