build wheels with CUDA 13.0.x, test wheels against mix of CTK versions#942
Conversation
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
| matrices: | ||
| - matrix: | ||
| dependencies: "latest" | ||
| packages: |
There was a problem hiding this comment.
Works around this:
DEPRECATION: Constraints are only allowed to take the form of a package name and a version specifier. Other forms were originally permitted as an accident of the implementation, but were undocumented. The new implementation of the resolver no longer supports these forms. A possible replacement is replacing the constraint with a requirement. Discussion can be found at pypa/pip#8210
ERROR: Constraints cannot have extras
There was a problem hiding this comment.
We probably want a better solution for this. Just listing the package name without the extra for dependencies: "oldest" is what I typically do for numba-cuda. https://github.com/rapidsai/rmm/blob/c6135d6ca689629fa68d1cce4dfb1980fa9780e2/dependencies.yaml#L369-L384
There was a problem hiding this comment.
I think that might work for that case because the other things pulled in by the numba-cuda[cu12,cu13] extras are pulled into the environment and pinned appropriately anyway through other dependencies.
This is a little different... moto[server] pulls in packages that otherwise wouldn't be in the environment at all https://github.com/getmoto/moto/blob/a3e1138d2010147be610a1d3ee6fced9fee3cf44/setup.cfg#L80
So we do need to ensure moto[server] (with the extra) makes it into the test environment somehow.
There was a problem hiding this comment.
I'm treating this comment as non-blocking, because here I think we're only talking about spelling in dependencies.yaml and not correctness of the outputs.
I opened an issue to track it: #945
I'll merge this as-is.
|
/ok to test |
jameslamb
changed the title
| matrices: | ||
| - matrix: | ||
| dependencies: "latest" | ||
| packages: |
There was a problem hiding this comment.
We probably want a better solution for this. Just listing the package name without the extra for dependencies: "oldest" is what I typically do for numba-cuda. https://github.com/rapidsai/rmm/blob/c6135d6ca689629fa68d1cce4dfb1980fa9780e2/dependencies.yaml#L369-L384
|
/merge |
…wheels against mix of CTK versions (#21671) Contributes to rapidsai/build-planning#257 * builds CUDA 13 wheels with the 13.0 CTK * ensures wheels ship with a runtime dependency of `nvidia-nvjitlink>={whatever-minor-version-they-were-built-against}` Contributes to rapidsai/build-planning#256 * updates wheel tests to cover a range of CTK versions (we previously, accidentally, were only testing the latest 12.x and 13.x) Other changes * ensures conda packages also take on floors of `libnvjitlink>={whatever-version-they-were-built-against}` ## Notes for Reviewers ### How I tested this Used wheels from similar PRs from RAPIDS dependencies, at build and test time: * rapidsai/kvikio#942 * rapidsai/rmm#2270 * rapidsai/ucxx#604 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: #21671
…wheels against mix of CTK versions (#5457) Fixes #5443 Contributes to rapidsai/build-planning#257 * builds CUDA 13 wheels with the 13.0 CTK * ensures wheels ship with a runtime dependency of `nvidia-nvjitlink>={whatever-minor-version-they-were-built-against}` Contributes to rapidsai/build-planning#256 * updates wheel tests to cover a range of CTK versions (we previously, accidentally, were only testing the latest 12.x and 13.x) Other changes * ensures conda packages also take on floors of `libnvjitlink>={whatever-version-they-were-built-against}` ## Notes for Reviewers ### How I tested this This uses wheels from similar PRs from RAPIDS dependencies, at build and test time: * rapidsai/cudf#21671 * rapidsai/kvikio#942 * rapidsai/raft#2971 * rapidsai/rmm#2270 * rapidsai/ucxx#604 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Gil Forsyth (https://github.com/gforsyth) URL: #5457
2 participants
Description
Contributes to rapidsai/build-planning#257
Contributes to rapidsai/build-planning#256